Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement Cppyy::GetAllCppNames #115

Merged

Conversation

Vipul-Cariappa
Copy link
Collaborator

Fixes test_regression.py::TestREGRESSION::test31_enum_in_dir

// Collect all known names of C++ entities under scope. This is useful for IDEs
// employing tab-completion, for example. Note that functions names need not be
// unique as they can be overloaded.
std::vector<std::string> cppnames_vec = Cpp::GetAllCppNames(scope);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change that interface to Cpp::GetAllCppNames(scope, cppnames_vec)

Vipul-Cariappa added a commit to Vipul-Cariappa/cppyy-compiler-research that referenced this pull request Nov 28, 2024
Copy link
Collaborator

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@vgvassilev vgvassilev merged commit bfea6ba into compiler-research:master Nov 28, 2024
12 checks passed
aaronj0 pushed a commit to compiler-research/cppyy that referenced this pull request Nov 28, 2024
@Vipul-Cariappa Vipul-Cariappa deleted the dev/GetAllCppNames branch December 4, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants