forked from wlav/cppyy-backend
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement Cppyy::GetAllCppNames
#115
Merged
vgvassilev
merged 2 commits into
compiler-research:master
from
Vipul-Cariappa:dev/GetAllCppNames
Nov 28, 2024
Merged
implement Cppyy::GetAllCppNames
#115
vgvassilev
merged 2 commits into
compiler-research:master
from
Vipul-Cariappa:dev/GetAllCppNames
Nov 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vipul-Cariappa
force-pushed
the
dev/GetAllCppNames
branch
from
November 27, 2024 14:59
4bf1119
to
ab91cc8
Compare
vgvassilev
reviewed
Nov 27, 2024
clingwrapper/src/clingwrapper.cxx
Outdated
// Collect all known names of C++ entities under scope. This is useful for IDEs | ||
// employing tab-completion, for example. Note that functions names need not be | ||
// unique as they can be overloaded. | ||
std::vector<std::string> cppnames_vec = Cpp::GetAllCppNames(scope); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should change that interface to Cpp::GetAllCppNames(scope, cppnames_vec)
Vipul-Cariappa
force-pushed
the
dev/GetAllCppNames
branch
from
November 28, 2024 13:12
ab91cc8
to
731db33
Compare
Vipul-Cariappa
added a commit
to Vipul-Cariappa/cppyy-compiler-research
that referenced
this pull request
Nov 28, 2024
vgvassilev
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
test_regression.py::TestREGRESSION::test31_enum_in_dir